Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing support for String.prototype.padStart() and padEnd() #429

Closed
aviv86 opened this issue Oct 22, 2017 · 4 comments
Closed

Missing support for String.prototype.padStart() and padEnd() #429

aviv86 opened this issue Oct 22, 2017 · 4 comments

Comments

@aviv86
Copy link

aviv86 commented Oct 22, 2017

No description provided.

@aviv86 aviv86 mentioned this issue Oct 22, 2017
Merged
@aviv86
Copy link
Author

aviv86 commented Oct 24, 2017

startsWith() and endsWith() are not supported as well

@maximburyak maximburyak mentioned this issue Oct 24, 2017
Closed
WestDiscGolf added a commit to WestDiscGolf/jint that referenced this issue Nov 3, 2017
@WestDiscGolf
padStart and padEnd sebastienros#429
911e41c
@WestDiscGolf WestDiscGolf mentioned this issue Nov 3, 2017
Merged
@WestDiscGolf
Copy link
Contributor

Would the suggested implentations here and here be enough if implemented? Or would the more "fullfilled" pollyfills be required?

sebastienros pushed a commit that referenced this issue Nov 10, 2017
@WestDiscGolf @sebastienros
Adding String.padStart and String.padEnd #429 (#434)
15807f0
@sebastienros
Copy link
Owner

@WestDiscGolf if you intend to implement the other two ones, and anything else after all, please follow the reference implementation from the specification, and not MDN. It will be easier to understand. But feel free to use the test cases from MDN.

@WestDiscGolf
Copy link
Contributor

@sebastienros sure thing! 👍

This was referenced Nov 25, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WestDiscGolf @sebastienros @aviv86