Missing support for String.prototype.startsWith #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return false; | ||
| } | ||
|
|
||
| return s.Remove(0, start).StartsWith(searchStr); |
There was a problem hiding this comment.
Better to use IndexOf(start, str) == 0
There was a problem hiding this comment.
Cool. Thanks for the feedback. Will update asap :-)
|
I did all the fixes, can you try to rebase the commit on top of dev? Or squash everything on this same branch? Github prevents me from doing it from the UI right now. |
|
@sebastienros All done :-) |
|
|
|
Sorry about that, obviously done it wrong. Not feeling great so will take another look in the morning. |
|
Don't worry, I will just do it |
sebastienros
force-pushed
the
startsWith
branch
from
7c5050b
to
0281b6a
Compare
|
@sebastienros thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address the issue of startsWith not currently supported. This is to address #440 which is linked to #429