-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows graphics changes #855
base: master
Are you sure you want to change the base?
Windows graphics changes #855
Conversation
…BIOSAssetTag from.
@shoustech wow, thank you! I will check it the upcoming days and if is also works here on my side, I will crate a new release. |
Removed unneeded if statements. Added a backup for when we do not recognize the monitor display technology.
Fixed an issue on mac systems where wifi.js was reporting an error when trying to list networks.
I have been using this change on a few hundred PCs for about 3-4 months now and it has been working without issue. I am going to be updating my agent and will be updating my systeminformation dependency. Would you like an updated pull request? I also have code we are using outside of the module that would be good features if you wanted the pull requests.
|
@shoustech i am really interested in the code to find out if bitlocker is set up. i could not find it in your fork, where could i find the code? |
Note:
I am not using the previously used variable
ssections
because I could not find a reliable way to map any of the displays to the values output. I can go back in and addpixelDepth
andmain
with the value from the main display inssections
as the default for all the monitors.Description
I am opening this pull request because after #853 was submitted I ended up looking at the commands being used to pull the information on windows and noticed that there was some room for improvement. I fixed an issue where in some situations the output would exclude displays. I have also added the fields
displayId
andproductionYear
which was previously only available on MacOS.Notable changes
The number of displays is now based on the variable
tsections
. I then match the InstanceName property to the Instance name property inmsections
andisections
. Fordsections
I am finding the correct display by matchingtsections.InstanceName
todsections.PNPDeviceID
After all of the objects associated with the display have been found the app will then pull variables in this order:
tsection
dsection
msection
and finally
isection
Since the output of
dsection
is the most complete I pulled what I could from that object first and then went down the list from there. If a variable was not pulled fromdsection
or the correlated object could not be found I would then fill in blank values or pull backup variables from the other objects.Also:
displayId
andproductionYear
Examples
In this situation I am using a RDP connection to a different desktop
Existing module
Modified module
Without RDP original code:
Without RDP modified code: