Added option to select protocol when creating a raw channel. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added optional parameter to set the protocol.
Added optional parameter to set the CAN protocol.
Added option to select the protocol.
Moved variable declaration to match authour style.
|
Great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I have a target that requires me to select a different protocol instead of the default CAN_RAW that is presently used when opening a socket.
I have added the option to pass the protocol. This is a sole addition and it will not break existing implementations that are using your package. I think my use case is rather rare but since it just adds flexibility I wonder if you would consider pulling it in.
Thanks again for your effort creating and maintaining this.