Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added section for treemodel filters, along with a full code example #64

Merged
merged 3 commits into from
Feb 8, 2015

Conversation

hadware
Copy link
Contributor

@hadware hadware commented Feb 5, 2015

There was no section on filters, whereas the old PyGTK tutorial had one... I used the old one to figure out how it works, but i think it's interesting to migrate the old doc to the new one.

There was also no truly complete code example in this chapter, i think adding one wasn't too much.

I'm not a native speaker so proof-read what i wrote if you think it globally fits your criteria.

PS: in the future, I think it also might be good to divide this section (or enrich it) to explain how filters work on TreeStore's, i wasn't able to find real tutorial on this matter. Same goes for TreeModelSort (even if it's redundant with the current Sort section, the class itself is more functionnal i think).

sebp added a commit that referenced this pull request Feb 8, 2015
Added section for treemodel filters, along with a full code example
@sebp sebp merged commit 6ebe921 into sebp:master Feb 8, 2015
@sebp
Copy link
Owner

sebp commented Feb 8, 2015

Thanks a lot, looks good!

@hadware
Copy link
Contributor Author

hadware commented Feb 8, 2015

I re-read it again, there are about 2-3 small mistakes that remained. I'm a bit new to github's "commit-protocol"... should I fix them on my own repo and make a pull-request, or would you prefer me point them out for you to correct them?.

Also, what about detailing on the TreeStore ?

@sebp
Copy link
Owner

sebp commented Feb 8, 2015

Am 08.02.2015 um 17:36 schrieb Hadrien:

I re-read it again, there are about 2-3 small mistakes that remained.
I'm a bit new to github's "commit-protocol"... should I fix them on my
own repo and make a pull-request, or would you prefer me point them out
for you to correct them?.

Also, what about detailing on the TreeStore ?


Reply to this email directly or view it on GitHub
#64 (comment).

Please file a new pull request with the changes.

If you want to add more information to the TreeStore model, I'd very
much appreciate it. If you have an update to the existing documentation,
simply file a new pull request as well.

@hadware
Copy link
Contributor Author

hadware commented Feb 8, 2015

Got it, i'll take care of it as soon as i can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants