RFE: bump minimum required version to 2.2.0 #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the SCMP_FLTATR_CTL_TSYNC attribute in NewFilter, and error out should that fail. Since the threads are hidden from the programmer, it is inherently unsafe to run without this bit set, as the runtime can and does create threads very early, which are used in subsequent operations (go routines), meaning that the filter might not be applied, see discussion in #17. Signed-off-by: Thordur Bjornsson <thorduri@secnorth.net>
pcmoore
changed the title
Closed
|
@thorduri We set TSync by default now, so I think this is obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the SCMP_FLTATR_CTL_TSYNC attribute in NewFilter, and error out should
that fail.
Since the threads are hidden from the programmer, it is inherently unsafe
to run without this bit set, as the runtime can and does create threads
very early, which are used in subsequent operations (go routines), meaning
that the filter might not be applied, see discussion in #17.
Signed-off-by: Thordur Bjornsson thorduri@secnorth.net