BUG: fix various bugs found when working on code coverage #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Moore <paul@paul-moore.com>
We recently changed how libseccomp handles syscall numbers that are not defined natively, but we missed test seccomp#15. Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
The clang compiler complains of a potential memory leak, this patch fixes it. Signed-off-by: Paul Moore <paul@paul-moore.com>
… tests This is a bit controversial as historically we've refrained from doing any tests that rely on the host kernel in the non-live tests, but I think enough time has past that we can do a simple seccomp_load() and not break the world's build/test platforms. The obvious big advantage is we are now testing the basic prctl()/seccomp() filter load infrastructure as part of the main regression test run. Signed-off-by: Paul Moore <paul@paul-moore.com>
Oddly, going from 16.04 to 18.04 results in about a 0.8% reduction in code coverage. Signed-off-by: Paul Moore <paul@paul-moore.com>
This was referenced Nov 6, 2019
|
FYI: this fixes issue #184. |
|
I had some other patches that were blocked on this PR so I decided to just add them to this PR since they are related to code coverage testing. |
drakenclimber
approved these changes
Nov 12, 2019
|
Merged at HEAD e5ef83b, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working to claw back some code coverage I ran across two problems which are fixed in this PR. The patches are small and should speak for themselves.