BUG: use openat instead of open in test 15 #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On arm64, __NR_open is not defined, openat is always used. Let's use openat instead, which is defined for architectures currently.
pcmoore
changed the title
|
Hi @keszybz, thanks for bringing this up, we were supposed to have fixed this in a previous PR but it looks like something went wrong with the merge and the fix was dropped. I've merged the original fix into the master branch via 1ecdddb; if you still see problems let us know. For reference, the original fix was part of PR #182 and can be found here: pcmoore@35803ce |
|
Yep, that should work too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On arm64, __NR_open is not defined, openat is always used. Let's use openat
instead, which is defined for architectures currently.