Make sure that a valid TCP over DNS message can be decoded #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guedou
force-pushed
the
dnstcp_check_length
branch
from
cc847a2
to
96b9c28
Compare
guedou
force-pushed
the
dnstcp_check_length
branch
from
96b9c28
to
eee80a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2408 +/- ##
=========================================
+ Coverage 87.37% 87.4% +0.03%
=========================================
Files 242 242
Lines 50656 50668 +12
=========================================
+ Hits 44261 44287 +26
+ Misses 6395 6381 -14
|
p-l-
reviewed
Jan 14, 2020
p-l-
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially fixes 2406. It is the root cause of the issue that triggers the recursion loop.