Modifications to PR#149 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When interface names are longer than 7 characters netstat will truncate them to the first 7 chars which leads to looking up an invalid interface name. We attempt to guess the name of the interface based on the output of ifconfig -l. If there is only one candate we consider that otherwise we ignore it.
…ais/scapy into osx_netstat_truncated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some modifications to PR#149 that aims to survive truncated interface names returned by
netstaton OS X. Compared to the original PR, this one adds a regression test to ensure that the patch works correctly.@hellais & @Osso could you confirm that this PR fixes your issues ? Thanks.
@p-l- could you squash when you will merge ?