Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radiotap: add support for fixed order Tx flag #2734

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Conversation

vanhoefm
Copy link
Contributor

This patch is part of my proposal to add a new bit to the Tx flags of the radiotap header. I consider the patch itself ready, but the code should only be merged if/once this addition has gone through radiotap's standardization process.

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #2734 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2734      +/-   ##
==========================================
- Coverage   88.29%   88.28%   -0.02%     
==========================================
  Files         251      251              
  Lines       53329    53329              
==========================================
- Hits        47089    47082       -7     
- Misses       6240     6247       +7     
Impacted Files Coverage Δ
scapy/layers/dot11.py 91.88% <100.00%> (ø)
scapy/layers/tls/automaton.py 86.46% <0.00%> (-3.01%) ⬇️
scapy/layers/ntp.py 91.89% <0.00%> (-0.55%) ⬇️
scapy/layers/inet.py 74.05% <0.00%> (-0.09%) ⬇️

@vanhoefm vanhoefm marked this pull request as ready for review October 19, 2020 07:58
@vanhoefm
Copy link
Contributor Author

These flags are now standardized, so the updated ORDER flag can be merged as well. Context: https://lore.kernel.org/radiotap/3a082d1643fc5980ab1f11acda7e855c3eed60c7.camel@sipsolutions.net/T/#t

@guedou
Copy link
Member

guedou commented Oct 19, 2020

Thanks for the update!

@guedou guedou merged commit e346256 into secdev:master Oct 19, 2020
@gpotter2
Copy link
Member

I'm surprised the TX field page wasn't updated: https://www.radiotap.org/fields/TX%20flags.html

@vanhoefm
Copy link
Contributor Author

@gpotter2
Copy link
Member

Cool, thanks for the info !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants