Fixed a bug in the sendrecv method when using multi-threading #417
Conversation
| @@ -140,6 +140,8 @@ def sndrcv(pks, pkt, timeout = None, inter = 0, verbose=None, chainCC=0, retry=0 | |||
| inp = [] | |||
| try: | |||
| inp, out, err = select(inmask,[],[], remaintime) | |||
| except error as e: | |||
There was a problem hiding this comment.
I don't really like continuing like that, as select.error can be differents errors... That's typically a place where bugs will hide
As the select.error is something like
(4, 'Interrupted system call')
Couldn't we check if the error is 4, and if so continue, otherwise raise ?
There was a problem hiding this comment.
Sorry I created the PR but had not finished my changes.
There was a problem hiding this comment.
Actually it's better to merge with the next except statement.
|
Failure on AppVeyor seems to be related to... AppVeyor ("Maximum number of retries (3) exceeded while executing database operations with 'SqlAzureExecutionStrategy'. See inner exception for the most recent failure."). Just re-launched a new build. |
|
@p-l- Yes thanks this fixes the bug. |
This is #267 with conflicts fixed + cleanup.
Fixes #267.