Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for S1G beacon parsing #4442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rkinder2023
Copy link

New feature for dot11.py, add support for S1G beacon parsing.

Includes changes to support extension frames (as much as needed for S1G beacon), as well as unit test to confirm the basics of an S1G beacon.

dot11 unit tests run, all pass.

fixes #4439

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.99%. Comparing base (1e857c9) to head (efef84f).

❗ There is a different number of reports uploaded between BASE (1e857c9) and HEAD (efef84f). Click for more details.

HEAD has 9 uploads less than BASE | Flag | BASE (1e857c9) | HEAD (efef84f) | |------|------|------| ||10|1|
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4442       +/-   ##
===========================================
- Coverage   81.50%   48.99%   -32.51%     
===========================================
  Files         353      346        -7     
  Lines       84394    78512     -5882     
===========================================
- Hits        68783    38468    -30315     
- Misses      15611    40044    +24433     
Files Coverage Δ
scapy/layers/dot11.py 54.26% <100.00%> (-37.15%) ⬇️

... and 262 files with indirect coverage changes

@rkinder2023
Copy link
Author

Note that this is not complete yet, but good enough to get S1G beacons parsed. Still to do is modify the core Dot11 class to add support for S1G beacon frame control field.

@rkinder2023
Copy link
Author

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.99%. Comparing base (1e857c9) to head (efef84f).

❗ There is a different number of reports uploaded between BASE (1e857c9) and HEAD (efef84f). Click for more details.
HEAD has 9 uploads less than BASE

Flag BASE (1e857c9) HEAD (efef84f)
10 1

Additional details and impacted files

Anyone know what went wrong here? Why did coverage go down so much?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for S1G beacon to dot11
1 participant