Assert failure in featurettes branch on OpenGL 3.2

[cosmic-linden]

Description

In materials featurette upstream (commit 7ed053d9a257087b76937d750b9f2b0c96f6df38), running on my local build, I get an assert crash when I set RenderMaxOpenGLVersion down to OpenGL 3.2 . The call stack implicates LLHeroProbeManager.

We disable reflection probes on OpenGL versions that don't support cubemaps. We should do this for mirrors as well. This could be related.

Call stack:

secondlife-bin.exe!LLGLSLShader::bind::__l13::<lambda>(int * ptr) Line 1027	C++
secondlife-bin.exe!void <lambda>(int *)::<lambda_invoker_cdecl>(int * ptr) Line 1027	C++
secondlife-bin.exe!crashdriver(void(*)(int *) callback) Line 1662	C++
secondlife-bin.exe!LLGLSLShader::bind() Line 1027	C++
secondlife-bin.exe!LLHeroProbeManager::generateRadiance(LLReflectionMap * probe) Line 403	C++
secondlife-bin.exe!LLHeroProbeManager::update() Line 250	C++
secondlife-bin.exe!display(int rebuild, float zoom_factor, int subfield, int for_snapshot) Line 668	C++
secondlife-bin.exe!LLAppViewer::doFrame() Line 1514	C++
secondlife-bin.exe!LLAppViewer::frame() Line 1347	C++
secondlife-bin.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * pCmdLine, int nCmdShow) Line 510	C++
[External Code]	

Specifically, this assert fails in LLGLSLShader::bind():

llassert(mProgramObject != 0);

[Dan-Linden]

Passed QA on Featurettes 7.1.8.9375512768.

No crash on Win10. Reflections and mirrors are both disabled as expected when set to OpenGL 3.2
No crash on Mac. However, on OpenGL 3.2, reflections and mirrors are still enabled. Appears that mac is not actually set to OpenGL 3.2 but rather 4.1 after checking About Second Life.