secondlife/viewer#1531: Fix crash of PBR terrain on Windows/Intel #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunitaiLinden
requested changes
May 28, 2024
indra/newview/app_settings/shaders/class1/deferred/pbrterrainF.glsl
Outdated
Show resolved
Hide resolved
RunitaiLinden
approved these changes
May 28, 2024
cosmic-linden
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(speculative fix, hope this works. davep to attempt repro on Wintel laptop)
Test plan
PBR terrain should work on Windows with Intel integrated graphics, without crashing.
To be extra thorough, try the following advanced settings combinations, and confirm none of them cause a crash:
RenderTerrainPBRDetail: 0, -1, -2, -3, or -4RenderMaxOpenGLVersion: If your testing computer supports a higher OpenGL version, try setting this value down to 4.4 instead, restart the viewer, and continue testing