This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
secrethub init with setup code #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new names reflect the kind of clients they create, making it easier to spot which type of client is used where.
jpcoenen
reviewed
Aug 13, 2020
There was a problem hiding this comment.
Tried it and it does work nicely 🎉
My comments are mainly abou the chunks of duplicate code (I think) I found. If they are actually duplicated, it makes the maintenance of this code a lot more difficult. So see if you can move some things to separate functions (if this makes sense).
Co-authored-by: Joris Coenen <jpcoenen@users.noreply.github.com>
jpcoenen
reviewed
Aug 14, 2020
This commit also makes the cli point to the version of the client containing the required changes.
florisvdg
reviewed
Sep 7, 2020
Co-authored-by: Floris van der Grinten <floris@grinten.com>
There is no valid use case where a user would have to enter it manually, so we can better remove this altogehter and direct users to the website.
There is no reason why a user would have to get there when he is not copying a command with a --setup-code flag.
Remove prompt for setup code
jpcoenen
approved these changes
Sep 7, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
--setup-codeflag for thesecrethub init commandallowing users to initialize accounts using setup codes.