Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix release/v1.5.1 #205

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Hotfix release/v1.5.1 #205

merged 3 commits into from
Aug 9, 2023

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Aug 9, 2023

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix

📜 Background

Issue Link: https://linear.app/xverseapp/issue/ENG-2581/unit-test-and-fix-fetch-fetchpendingstxtransactions-function
Context Link (if applicable):

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • fix logic in fetchStxPendingTransactions
  • add unit tests

Impact:

  • fetchStxPendingTransactions
  • fetchStxAddressData (total_transactions)

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@teebszet
1.5.0
8808940
@teebszet
fix: fetch pending stx transactions and unit test
47918fd 
chore: bump minor version

chore: fix error in package.json
@teebszet teebszet changed the title Release/v1.5.1 Hotfix release/v1.5.1 Aug 9, 2023
@teebszet teebszet merged commit b76adc3 into develop Aug 9, 2023
2 checks passed
@teebszet teebszet mentioned this pull request Aug 9, 2023
Closed
11 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Test this PR with npm i @secretkeylabs/xverse-core@1.5.1-ac4f909

@teebszet teebszet deleted the release/v1.5.1 branch October 31, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yknl yknl yknl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teebszet @yknl