Hotfix release/v1.5.1 (#205)

* 1.5.0

* fix: fetch pending stx transactions and unit test

chore: bump minor version

chore: fix error in package.json

api/helper.ts

@@ -151,20 +151,24 @@ export function parseBtcTransactionData(
   return parsedTx;
 }
 
-export function deDuplicatePendingTx({
+export function getUniquePendingTx({
   confirmedTransactions,
   pendingTransactions,
 }: {
   confirmedTransactions: StxTransactionData[];
   pendingTransactions: StxMempoolTransactionData[];
 }): StxMempoolTransactionData[] {
-  const txArray: StxMempoolTransactionData[] = [];
-  for (const tx of [...confirmedTransactions, ...pendingTransactions]) {
-    if (!txArray.find((t) => t.txid === tx.txid)) {
-      txArray.push(tx as StxMempoolTransactionData);
-    }
+  if (!pendingTransactions.length) {
+    return pendingTransactions;
   }
-  return txArray;
+  return [
+    ...new Map(
+      pendingTransactions
+        .filter((pendingTx) => pendingTx.incoming !== true)
+        .filter((pendingTx) => !confirmedTransactions.find((confirmedTx) => confirmedTx.txid === pendingTx.txid))
+        .map((m) => [m.txid, m]),
+    ).values(),
+  ];
 }
 
 export function mapTransferTransactionData({

api/stacks.ts

@@ -31,8 +31,8 @@ import {
 import { API_TIMEOUT_MILLI } from '../constant';
 import { AddressToBnsResponse, CoinMetaData, CoreInfo, DelegationInfo } from '../types/api/stacks/assets';
 import {
-  deDuplicatePendingTx,
   getNetworkURL,
+  getUniquePendingTx,
   mapTransferTransactionData,
   parseMempoolStxTransactionsData,
   parseStxTransactionData,
@@ -151,7 +151,7 @@ export async function fetchStxAddressData(
   ]);
 
   const confirmedCount = confirmedTransactions.totalCount;
-  const mempoolCount = deDuplicatePendingTx({
+  const mempoolCount = getUniquePendingTx({
     confirmedTransactions: confirmedTransactions.transactionsList,
     pendingTransactions: mempoolTransactions.transactionsList,
   }).length;
@@ -357,6 +357,7 @@ export async function fetchAddressOfBnsName(
 }
 
 export async function fetchStxPendingTxData(stxAddress: string, network: StacksNetwork): Promise<StxPendingTxData> {
+
   const [confirmedTransactions, mempoolTransactions] = await Promise.all([
     getConfirmedTransactions({
       stxAddress,
@@ -370,10 +371,10 @@ export async function fetchStxPendingTxData(stxAddress: string, network: StacksN
     }),
   ]);
 
-  const pendingTransactions = deDuplicatePendingTx({
+  const pendingTransactions = getUniquePendingTx({
     confirmedTransactions: confirmedTransactions.transactionsList,
     pendingTransactions: mempoolTransactions.transactionsList,
-  }).filter((tx) => tx.incoming === false);
+  });
 
   return {
     pendingTransactions,

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@secretkeylabs/xverse-core",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "description": "",
   "main": "dist/index.js",
   "dependencies": {

tests/api/helper.test.ts

@@ -0,0 +1,68 @@
+import { describe, expect, it } from 'vitest';
+import { getUniquePendingTx } from 'api/helper';
+import { StxMempoolTransactionData, StxTransactionData } from 'types/*';
+
+describe('getUniquePendingTx', () => {
+  [
+    {
+      name: 'returns empty for no pending transactions',
+      inputs: {
+        confirmedTransactions: [
+          { senderAddress: 'address1', txid: 'tx1' } as StxTransactionData,
+          { senderAddress: 'address1', txid: 'tx2' } as StxTransactionData,
+        ],
+        pendingTransactions: [],
+      },
+      expected: [],
+    },
+    {
+      name: 'returns pending transactions not also seen in confirmed transactions',
+      inputs: {
+        confirmedTransactions: [
+          { senderAddress: 'address1', txid: 'tx1' } as StxTransactionData,
+          { senderAddress: 'address1', txid: 'tx2' } as StxTransactionData,
+        ],
+        pendingTransactions: [
+          { senderAddress: 'address1', txid: 'tx2' } as StxMempoolTransactionData,
+          { senderAddress: 'address1', txid: 'tx3' } as StxMempoolTransactionData,
+        ],
+      },
+      expected: [{ senderAddress: 'address1', txid: 'tx3' } as StxMempoolTransactionData],
+    },
+    {
+      name: 'returns unique pending transactions not also seen in confirmed transactions',
+      inputs: {
+        confirmedTransactions: [
+          { senderAddress: 'address1', txid: 'tx1' } as StxTransactionData,
+          { senderAddress: 'address1', txid: 'tx2' } as StxTransactionData,
+        ],
+        pendingTransactions: [
+          { senderAddress: 'address1', txid: 'tx2' } as StxMempoolTransactionData,
+          { senderAddress: 'address1', txid: 'tx3' } as StxMempoolTransactionData,
+          { senderAddress: 'address1', txid: 'tx3' } as StxMempoolTransactionData,
+        ],
+      },
+      expected: [{ senderAddress: 'address1', txid: 'tx3' } as StxMempoolTransactionData],
+    },
+    {
+      name: 'returns only pending transactions which are not incoming',
+      inputs: {
+        confirmedTransactions: [
+          { senderAddress: 'address1', txid: 'tx1' } as StxTransactionData,
+          { senderAddress: 'address1', txid: 'tx2' } as StxTransactionData,
+        ],
+        pendingTransactions: [
+          { senderAddress: 'address1', txid: 'tx2' } as StxMempoolTransactionData,
+          { senderAddress: 'address1', txid: 'tx3' } as StxMempoolTransactionData,
+          { senderAddress: 'address1', txid: 'tx3' } as StxMempoolTransactionData,
+          { senderAddress: 'address1', txid: 'tx4', incoming: true } as StxMempoolTransactionData,
+        ],
+      },
+      expected: [{ senderAddress: 'address1', txid: 'tx3' } as StxMempoolTransactionData],
+    },
+  ].forEach(({ name, inputs, expected }) => {
+    it(name, () => {
+      expect(getUniquePendingTx(inputs)).toEqual(expected);
+    });
+  });
+});