Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide a getOrdinalsInUtxos if found function #317

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

teebszet
Copy link
Member

πŸ”˜ PR Type

  • Bugfix
  • Refactoring (no functional changes, no api changes)

πŸ“œ Background

πŸ”„ Changes

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:
fix: move critical logic for ignoring 404s into core

πŸ–Ό Screenshot / πŸ“Ή Video

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Copy link
Contributor

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@5.2.0-900ef62

@teebszet teebszet merged commit 86c7bc9 into develop Dec 12, 2023
3 checks passed
@teebszet teebszet deleted the fix/get-ordinals-in-utxos-if-found branch December 12, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants