Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-3427] fix: allow-404-get-utxos-from-psbt #709

Merged
merged 6 commits into from
Dec 13, 2023

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Dec 11, 2023

πŸ”˜ PR Type

  • Bugfix

πŸ“œ Background

https://linear.app/xverseapp/issue/ENG-3427

depends on secretkeylabs/xverse-core#317

πŸ”„ Changes

  • fix: handle 404s from the get ordinals in utxo endpoint when detecting for the sign psbt screen

Impact:

  • sign psbt screen only

πŸ–Ό Screenshot / πŸ“Ή Video

with fix:
image

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

victorkirov
victorkirov previously approved these changes Dec 11, 2023
@teebszet teebszet changed the base branch from release/v0.26.0 to develop December 11, 2023 07:46
@teebszet teebszet dismissed victorkirov’s stale review December 11, 2023 07:46

The base branch was changed.

@teebszet teebszet force-pushed the fix/allow-404-get-utxos-from-psbt branch from 918bccc to 13712b4 Compare December 11, 2023 07:47
fedeerbes
fedeerbes previously approved these changes Dec 11, 2023
@teebszet teebszet changed the title fix: allow-404-get-utxos-from-psbt [ENG-3427] fix: allow-404-get-utxos-from-psbt Dec 12, 2023
victorkirov
victorkirov previously approved these changes Dec 12, 2023
Copy link

@DuskaT021
Copy link
Contributor

@teebszet left just one comment in the ticket

@teebszet
Copy link
Member Author

needs reapproval after the core version was updated @DuskaT021

@teebszet teebszet requested review from DuskaT021 and removed request for victorkirov December 12, 2023 09:56
@teebszet teebszet merged commit 71772d9 into develop Dec 13, 2023
2 checks passed
This was referenced Dec 18, 2023
@teebszet teebszet deleted the fix/allow-404-get-utxos-from-psbt branch February 26, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants