Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show BNS name with stacks address in Send Form Screen #220

Closed
Imamah-Zafar opened this issue Jan 30, 2023 · 0 comments · Fixed by #227
Closed

Show BNS name with stacks address in Send Form Screen #220

Imamah-Zafar opened this issue Jan 30, 2023 · 0 comments · Fixed by #227
Assignees
Labels
enhancement New feature or request

Comments

@Imamah-Zafar
Copy link
Contributor

Show BNS name to user if user enters stacks address. If the user enters BNS name show the associated address.

@Imamah-Zafar Imamah-Zafar added the enhancement New feature or request label Jan 30, 2023
@Imamah-Zafar Imamah-Zafar added this to the Sprint 26 - Feb 13 milestone Jan 30, 2023
@Imamah-Zafar Imamah-Zafar linked a pull request Feb 2, 2023 that will close this issue
8 tasks
@yknl yknl closed this as completed in #227 Feb 16, 2023
dhriaznov added a commit that referenced this issue Jul 9, 2024
* Add btc send screen skeleton

* Implement MAX

* extract amount selector to component

* Add max dust filtered callout

* Fix minor styling

* Add fee display

* Implement fee selection

* Add insufficient funds on fee selector

* add insufficient funds message on custom fee selector

* Add insufficient funds gate

* fix some todos

* Add min and max fee rate

* fix container styling

* fix styling

* Fix fee summary on confirm page

* fix some component interactions

* fix a few minor bugs

* fix rbf typing

* Close window if ledger

* Update src/app/ui-library/input.tsx

Co-authored-by: Jordan K. <65149726+jordankzf@users.noreply.github.com>

* Update src/app/ui-library/input.tsx

Co-authored-by: Jordan K. <65149726+jordankzf@users.noreply.github.com>

* Add address editable field

* chore: package-lock exact version

* refactor: use classnames for variants in ui-library button

and default to currentColor in spinner

* refactor: use css classnames in ui input

and add the disabled styles

* fix: edit and pencil icon row

* fix: recipient input next should be disabled when error

and fix up btc amount selector button states

* fix: confirm/cancel translation keys

* Update core

* Remove unneeded toNumbers

* Move error text to feedback

* add new for BigNumber

* Make sats/vByte consistent

* Fix fee select styling

* Fix input styling

* switch to new spinner

* Factor out InputScreen from RecipientSelector

* Update InputScreen to accept ReactNode

* Step 1: Select Recipient

* [WIP] Step 2: Select Amount

* stxAmountSelector bug fixes

* [WIP] Step 3

* Forward AND reverse BNS lookup

* Indented feedback

* send async

* Step3Confirm adapter

* wip send max

* chore: bump core version

* fix: rotate faders icon

* Revert "Fix fee select styling"

This reverts commit a750d7b.

* fix: minor spacing, styling, and colour fixes

* fix: react key warning fix

* fees

* bump core

* Fix api

* fees

* apply fee

* remove feeoverride

* Don't log insufficient funds message

* Fix insufficient amount on load

* Enable rbf on txns

* Remove comments

* avoid calling setState twice

* Rename btcRecipientSelector

* Address Vic feedback

* address PR comments

* fix: change variant name according to zeroheight

* fix: use the correct variant for memo

* feat: apply stx fee cap logic

* fix: setting recipient address

* fix: use correct hooks

* fix: stx fee on send screen

* some more fixes

* feat: confirm stx fees (#256)

* feat: confirm STX UI

* chore: select fee rate in confirm stx

* fix: fee component

* feat: nonce settings in STX confirm

* fix: micro stacks conversion

* feat: confirm stx transactions fee

* chore: localization

* fix: fee in confirm stx

* refactor: remove feeOverride param

---------

Co-authored-by: Den <36603049+dhriaznov@users.noreply.github.com>

* fix: UI issues

* remove logs

* fix: disable send max once set

* fix: styles

* fix: cancel flow

* Fix the microStxToStx func helper import

* Remove unused code, add css transition

* Reuse the CrossButton component

* Redesign edit nonce popup, move styles to a separate file, use ui-library components

* Make some code and css fixes

* Check if insufficient funds when editing stx tx fee

* Make some code tweaks

* Make some code tweaks

* Make some code tweaks

* Make some code tweaks

* Fix selected fee state, add autofocus for the send stx flow

* fix the MAX button toggling, add autofocus for send btc flow, tweak some css

* Add autofocus for send rune flow

* Make some code tweaks

* Move the styles and component from CreateInscription to the separate files

* Add stx tx memo validation, fix horizontal scroll

* Fix the network fee fiat value display

* Fix the console error when it deserialized tx before is has been set

* Fix the ledger flow for stx sending

* Fix the merging errors

* Fix stx fee logic - ENG-4529 (#354)

* Fix stx fee calc

* Remove unused state

* Set the fees for stx txns before signing them

* Use available balance for stx txs

* Tweak the Edit button UI

* Add a try-catch

* Fix fee rate calcs

---------

Co-authored-by: Denys Hriaznov <hriaznov.dev@gmail.com>

* Fix typo recepientAddress -> recipientAddress

* Add a todo comment

* STX E2E tests skipped as screens changed

* Fix STX tx validation

* Add a handleGoBack func

---------

Co-authored-by: Victor Kirov <victor.kirov@gmail.com>
Co-authored-by: Jordan K. <65149726+jordankzf@users.noreply.github.com>
Co-authored-by: Tim Man <tim@secretkeylabs.com>
Co-authored-by: jordankzf <jordan@secretkeylabs.com>
Co-authored-by: Den <36603049+dhriaznov@users.noreply.github.com>
Co-authored-by: Denys Hriaznov <hriaznov.dev@gmail.com>
Co-authored-by: Christine Pinto <chrissie2788@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants