Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors in PSBT signing request without crashing #310

Closed
yknl opened this issue Mar 19, 2023 · 0 comments
Closed

Handle errors in PSBT signing request without crashing #310

yknl opened this issue Mar 19, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@yknl
Copy link
Contributor

yknl commented Mar 19, 2023

Component

Sign PSBT request

Severity

Choose one:

  • Major (Unable to proceed on a journey)

Summary

When PSBT parsing throws an error, it should not crash. But instead show the error in the UI.

image

Reproduce steps

  1. Run the sats connect example app https://github.com/secretkeylabs/sats-connect-example
  2. Change the psbtBase64 param to something invalid for the sign transaction request
  3. Press Sign transaction

Expected result

Nice UI showing that the PSBT was invalid and cannot be processed

Actual result

Crash

Remark

(Optional)

@yknl yknl added the bug Something isn't working label Mar 19, 2023
@yknl yknl added this to the Sprint 29 - Mar 27 milestone Mar 19, 2023
@yknl yknl closed this as completed Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants