Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show disclaimer psbt sign no broadcast #320

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

m-aboelenein
Copy link
Member

@m-aboelenein m-aboelenein commented Mar 20, 2023

PR Type

What kind of change does this PR introduce?

  • Enhancement

What is the current behavior?

Resolved: #317 #310 #311 #312

What is the new behavior?

  • A Disclaimer is shown when the wallet is not required to broadcast the tx after the user signs the psbt
  • the fees section of the psbt is hidden
  • handle invalid psbt error
  • show correct message for signing error
  • changed network mismatch error message

Screenshot / Video

  • Signing without broadcast

Screenshot 2023-03-20 at 2 48 02 PM

  • get Address Network Error

Screenshot 2023-03-20 at 5 26 27 PM

  • Invalid PSBT

Screenshot 2023-03-20 at 5 28 49 PM

@m-aboelenein m-aboelenein self-assigned this Mar 20, 2023
@m-aboelenein m-aboelenein added the enhancement New feature or request label Mar 20, 2023
@m-aboelenein m-aboelenein added this to the Sprint 29 - Mar 27 milestone Mar 20, 2023
yknl
yknl previously approved these changes Mar 20, 2023
@yknl yknl merged commit 7825e88 into develop Mar 20, 2023
@m-aboelenein m-aboelenein deleted the enhancement/psbt-sign-not-broadcasted branch March 20, 2023 17:17
dhriaznov added a commit that referenced this pull request Jul 9, 2024
…on (#320)

* [ENG-4430] Use feature flags from API to disable swaps on web-extension

* Add featureflag check

Update Playwright

* Revert "Add featureflag check"

This reverts commit 894cb5acfbed0da7d7d433050553b9a5582789d3.

* Adjust E2E test for swap button

* Update the xverse-core version

---------

Co-authored-by: Christine Pinto <chrissie2788@gmail.com>
Co-authored-by: fede erbes <fedeerbes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show transaction not being broadcasted after signing
2 participants