Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error message on getAddress calls #311

Closed
yknl opened this issue Mar 19, 2023 · 0 comments
Closed

Incorrect error message on getAddress calls #311

yknl opened this issue Mar 19, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@yknl
Copy link
Contributor

yknl commented Mar 19, 2023

Component

Sats connect getAddress and signTransaction calls

Severity

Choose one:

  • Trivial (Some UI issue)

Summary

When the getAddress request has a network mismatch, for example requested Mainnet but wallet is in Testnet, the resulting error message should not be "Transaction failed". No transaction was taking place. It should instead show a more friendly error message, something along the lines of "Mismatched network", "The app is requesting your wallet address for a different network. You may have to switch your active network in wallet settings. "

image

Reproduce steps

  1. Run the sats connect example app https://github.com/secretkeylabs/sats-connect-example
  2. Change the getAddress request network to a different network than the wallet
  3. Press Connect

Expected result

Show an appropriate error.

Actual result

Shows a transaction failed error.

Remark

(Optional)

@yknl yknl added the bug Something isn't working label Mar 19, 2023
@yknl yknl added this to the Sprint 29 - Mar 27 milestone Mar 19, 2023
@yknl yknl changed the title Incorrect error message on getAddress and signTransaction calls Incorrect error message on getAddress calls Mar 19, 2023
@yknl yknl closed this as completed Mar 27, 2023
dhriaznov pushed a commit that referenced this issue Jul 9, 2024
* fix sanity check

* remove sanity check flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants