Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error message on signTransaction calls #312

Closed
yknl opened this issue Mar 19, 2023 · 0 comments
Closed

Incorrect error message on signTransaction calls #312

yknl opened this issue Mar 19, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@yknl
Copy link
Contributor

yknl commented Mar 19, 2023

Component

Sats connect sign transaction prompt

Severity

Choose one:

  • Trivial (Some UI issue)

Summary

When PSBT transaction signing fails, the message should be "Failed to sign transaction" instead of "Transaction failed"

telegram-cloud-photo-size-1-4949507921385991146-x

Reproduce steps

  1. Run the sats connect example app https://github.com/secretkeylabs/sats-connect-example
  2. Try to sign the example partially signed transaction with the wallet as is
  3. See error after confirming the signing.

Expected result

show correct error message

Actual result

incorrect error message

Remark

(Optional)

@yknl yknl added the bug Something isn't working label Mar 19, 2023
@yknl yknl added this to the Sprint 29 - Mar 27 milestone Mar 19, 2023
@yknl yknl closed this as completed Mar 27, 2023
dhriaznov added a commit that referenced this issue Jul 9, 2024
* Some e2e test improvements

* Add startup timeout

* Address PR comment

---------

Co-authored-by: Den <36603049+dhriaznov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants