Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: settings layover #657

Conversation

abdulhaseeb4239
Copy link
Contributor

@abdulhaseeb4239 abdulhaseeb4239 commented Nov 13, 2023

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

Unable to enter password while resetting password because of layover to disable rare sats option.

Issue Link: https://linear.app/xverseapp/issue/ENG-3080/transparent-component-may-block-the-user-wants-to-reset-the-wallet
Context Link (if applicable):

🔄 Changes

  • removed the zIndex from disabled settings option

Impact:

  • settings, reset wallet UI

🖼 Screenshot / 📹 Video

Screen.Recording.2023-11-13.at.5.29.53.PM.mov

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Copy link

@blehitsahmad
Copy link

@abdulhaseeb4239 this is good to merge -- comment left in the corresponding ticket.

@abdulhaseeb4239 abdulhaseeb4239 merged commit 01d1608 into develop Nov 15, 2023
2 checks passed
@teebszet teebszet mentioned this pull request Nov 21, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants