Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: follow i18n next doc about plurals #661

Merged
merged 1 commit into from
Nov 14, 2023
Merged

chore: follow i18n next doc about plurals #661

merged 1 commit into from
Nov 14, 2023

Conversation

fedeerbes
Copy link
Contributor

🔘 PR Type

  • Enhancement

📜 Background

This PR add the plural form following i18n-next docs for item(s)
https://www.i18next.com/translation-function/plurals

Issue Link: #ENG-3209

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@fedeerbes fedeerbes self-assigned this Nov 14, 2023
@fedeerbes fedeerbes merged commit 09870db into imamahzafar/eng-2807-stacks-nft-tab-data-fetching-pagination-and-load-more-button Nov 14, 2023
@fedeerbes fedeerbes deleted the chore/ENG-3209/better-management-of-1-item-xx-items branch November 14, 2023 13:22
teebszet added a commit that referenced this pull request Nov 21, 2023
@Imamah-Zafar @teebszet
@abdulhaseeb4239 @fedeerbes
feat: STX NFTs Tab (#634)
c545608 
* Add hook to get nft collection data

* Update stx collectible UI

* Make NFT collage for collections

* Fix on click function

* fix import

* Update NFT Collection Page & NFT Detail Page (#633)

* Update NFT Detail UI

* Use hook to get collection data

* Add NFT Collection screen

* Fix navigation

* Remove hard coded address

* Fix bns name navigation

* refactor: use array for cache key

* Turn off no-nested-ternary rule globally

* Move nft util functions to a seperate file

* fix: remove unnecessary use mutation in nft details

and some other bug fixes

* fix: add the useResetUserFlow hook to nft collection page

* refactor: remove nftData from redux store

use the react-query cache instead, and fixes bug where some nftData was
not being stored

* fix: add isLoading state back to nftdetail and route to send with id

* fix: react console errors and send nft finishes at dashboard screen

* feat: add sticky tabs to collectibles dashboard

* refactor: separate use nft dashboard to separate file

* fix: bns detail page works

* chore: use core version with some updates

* fix: make bns names in collection screen not clickable and display name

* chore: enable stx test address from localstorage

* fix: button width for gallery view (#650)

* fix: open NFT gamma link (#649)

* fix: open nft page on gamma

* refactor: gamma url

* fix: metaData

* fix: show snackbar if NFT metadata is failed to fetch (#648)

* fix: show snackbar if nft metadata is failed to fetch

* fix: snackbar styling

* feat: revamp stacks nfts send to screen (#653)

* feat: revamp the send nft screen

* fix: back button display should rely on back history not ledger account

* fix: ledger accounts should only open in new tab when not already in full screen

otherwise it is annoying

* fix: add the bns name resolver to send nft form

* fix: opening a send-nft from ledger should open responsive screen

and debounce the stx address -> bns name resolver

* fix: some nft images are still showing the moon loader spinner it should be (#654)

* chore: tweak BetterBarLoader component to receive string as width and height in order to user percentages

* fix: key prop in nft collection screen

* fix: hardcoded placeholder size values and replace error icon with the new one

* fix: NFT detail screen UI (#655)

* fix: detail screen UI

* fix: UI alignments

* fix: buttons spacing

* feat: hook items count with correct values (#658)

* fix: column gap on tiles skeleton loader

* chore: update core version

* chore: follow i18n next doc about plurals (#661)

* fix: extension crashes when closing the broadcast success screen (#662)

* fix: wrong background color on transaction status screens

* fix: wrong navigation routes on transaction status screen

* fix: copy on inscription complete screen

* fix: z index on sticky tabs list and modals, popups (#665)

* refactor: collectibles fetch (#666)

* refactor: adapt to core refactor of stx collectibles

* fix: add back the check for metadata before nav to nft detail screen

* fix: use 24 hour staleTime for nft details to match mobile

* refactor: remove unused utils function

* fix: add react-is-visible to virtualise nft tab and nft collection page

* chore: bump core version with duplicate nft fix

* chore: bump core version

* chore: update core version and remove total_nft

* fix: bns image size and disable click on bns item (#668)

---------

Co-authored-by: Tim Man <tim@secretkeylabs.com>
Co-authored-by: Abdul Haseeb <haseeb4239@gmail.com>
Co-authored-by: fede erbes <fedeerbes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DuskaT021 DuskaT021 DuskaT021 approved these changes

@teebszet teebszet Awaiting requested review from teebszet

@abdulhaseeb4239 abdulhaseeb4239 Awaiting requested review from abdulhaseeb4239

Assignees

@fedeerbes fedeerbes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fedeerbes @DuskaT021