-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some nft images are still showing the moon loader spinner it should be #654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… height in order to user percentages
teebszet
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing 🤩
teebszet
merged commit Nov 13, 2023
ec5d63b
into
imamahzafar/eng-2807-stacks-nft-tab-data-fetching-pagination-and-load-more-button
fedeerbes
deleted the
fix/ENG-3202/some-nft-images-are-still-showing-the-moon-loader-spinner-it-should-be
branch
November 14, 2023 08:09
teebszet
added a commit
that referenced
this pull request
Nov 21, 2023
* Add hook to get nft collection data * Update stx collectible UI * Make NFT collage for collections * Fix on click function * fix import * Update NFT Collection Page & NFT Detail Page (#633) * Update NFT Detail UI * Use hook to get collection data * Add NFT Collection screen * Fix navigation * Remove hard coded address * Fix bns name navigation * refactor: use array for cache key * Turn off no-nested-ternary rule globally * Move nft util functions to a seperate file * fix: remove unnecessary use mutation in nft details and some other bug fixes * fix: add the useResetUserFlow hook to nft collection page * refactor: remove nftData from redux store use the react-query cache instead, and fixes bug where some nftData was not being stored * fix: add isLoading state back to nftdetail and route to send with id * fix: react console errors and send nft finishes at dashboard screen * feat: add sticky tabs to collectibles dashboard * refactor: separate use nft dashboard to separate file * fix: bns detail page works * chore: use core version with some updates * fix: make bns names in collection screen not clickable and display name * chore: enable stx test address from localstorage * fix: button width for gallery view (#650) * fix: open NFT gamma link (#649) * fix: open nft page on gamma * refactor: gamma url * fix: metaData * fix: show snackbar if NFT metadata is failed to fetch (#648) * fix: show snackbar if nft metadata is failed to fetch * fix: snackbar styling * feat: revamp stacks nfts send to screen (#653) * feat: revamp the send nft screen * fix: back button display should rely on back history not ledger account * fix: ledger accounts should only open in new tab when not already in full screen otherwise it is annoying * fix: add the bns name resolver to send nft form * fix: opening a send-nft from ledger should open responsive screen and debounce the stx address -> bns name resolver * fix: some nft images are still showing the moon loader spinner it should be (#654) * chore: tweak BetterBarLoader component to receive string as width and height in order to user percentages * fix: key prop in nft collection screen * fix: hardcoded placeholder size values and replace error icon with the new one * fix: NFT detail screen UI (#655) * fix: detail screen UI * fix: UI alignments * fix: buttons spacing * feat: hook items count with correct values (#658) * fix: column gap on tiles skeleton loader * chore: update core version * chore: follow i18n next doc about plurals (#661) * fix: extension crashes when closing the broadcast success screen (#662) * fix: wrong background color on transaction status screens * fix: wrong navigation routes on transaction status screen * fix: copy on inscription complete screen * fix: z index on sticky tabs list and modals, popups (#665) * refactor: collectibles fetch (#666) * refactor: adapt to core refactor of stx collectibles * fix: add back the check for metadata before nav to nft detail screen * fix: use 24 hour staleTime for nft details to match mobile * refactor: remove unused utils function * fix: add react-is-visible to virtualise nft tab and nft collection page * chore: bump core version with duplicate nft fix * chore: bump core version * chore: update core version and remove total_nft * fix: bns image size and disable click on bns item (#668) --------- Co-authored-by: Tim Man <tim@secretkeylabs.com> Co-authored-by: Abdul Haseeb <haseeb4239@gmail.com> Co-authored-by: fede erbes <fedeerbes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
📜 Background
This PR replace the older loading nft for a skeleton and fixes some issues in layout and wrong key prop values
Issue Link: #ENG-3202
🔄 Changes
🖼 Screenshot / 📹 Video
Screen.Recording.2023-11-10.at.11.49.49.mov
Screen.Recording.2023-11-10.at.11.37.21.mov
✅ Review checklist
Please ensure the following are true before merging: