fix: cap stx contract call fees #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
m-aboelenein
approved these changes
Dec 19, 2023
This was referenced Dec 19, 2023
teebszet
added a commit
that referenced
this pull request
Dec 20, 2023
* fix: cap stx contract call fees (#722) * fix: cap stx contract call fees * chore: update core version * chore: bump to core 6.0.1 * release: v0.26.2 --------- Co-authored-by: Tim Man <tim@secretkeylabs.com> Co-authored-by: GitHub Actions Bot <>
dhriaznov
pushed a commit
that referenced
this pull request
Dec 21, 2023
* fix: cap stx contract call fees * chore: update core version * chore: bump to core 6.0.1
dhriaznov
added a commit
that referenced
this pull request
Jan 11, 2024
* [ENG-3436] chore: Make some code refactoring for RBF in the extension * Make some code fixes * Make some code fixes * fix: put speed up screen in another scrollable container * Make some code tweaks according to PR review comments * Remove the unused import * fix nonce not being set correctly for tx requests * fix nonce calc persisted * [ENG-3455] fix: Fix the sharp fee change on tx confirmation * release v0.26.1 * package-lock update * fix: cap stx contract call fees (#722) * fix: cap stx contract call fees * chore: update core version * chore: bump to core 6.0.1 * [ENG-3474] feat: Make UI for STX RBF in the extension * Add the `useRbfTransactionData` hook * Add some logic for stx rbf * Add some logic for stx rbf * Improve the stx rbf logic * Improve the stx rbf logic * Add the insufficient funds check * Add ledger signing and broadcasting for stx rbf * Add the fee cap * Allow decimal fee for custom stx rbf * Fix the loading state in the rbf hook * Remove the todo comment * Remove the `convertStringHexToBufferReader` helper func * Round up the minimum rbf fee for stx txs * Create separate btc and stx rbf components * Remove the old todo comment * improve the stx rbf logic * Make some small code tweaks after the PR review * Pass the seedVault.getSeed func * Update the useRbfTransactionData hook * Update the rbf logic --------- Co-authored-by: Tim Man <tim@secretkeylabs.com> Co-authored-by: Mahmoud Aboelenein <mahmoud@secretkeylabs.com> Co-authored-by: Yukan <yukanliao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
What kind of change does this PR introduce?
📜 Background
stackerDAO reported really high fees when stacking via their dapp here: https://app.stackingdao.com/stack
we are taking fee estimates from the hiro endpoint https://api.hiro.so/v2/fees/transaction,
but the endpoint currently responds with really high estimates (~50STX).
this PR will set the fee capped at the threshold determined from our xverse-api (currently 1STX)
depends on: secretkeylabs/xverse-core#324
🔄 Changes
Impact:
🖼 Screenshot / 📹 Video
✅ Review checklist
Please ensure the following are true before merging: