[ENG-3474] feat: Make UI for STX RBF in the extension #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-for-rbf-in-the-extension
…-for-rbf-in-the-extension
…-for-rbf-in-the-extension
* fix: cap stx contract call fees * chore: update core version * chore: bump to core 6.0.1
8 tasks
teebszet
reviewed
Jan 9, 2024
teebszet
reviewed
Jan 9, 2024
teebszet
reviewed
Jan 9, 2024
teebszet
reviewed
Jan 10, 2024
teebszet
reviewed
Jan 10, 2024
teebszet
reviewed
Jan 10, 2024
teebszet
previously approved these changes
Jan 10, 2024
teebszet
reviewed
Jan 10, 2024
Comment on lines
8
to
12
| stxToMicrostacks, | ||
| StxTransactionData, | ||
| } from '@secretkeylabs/xverse-core'; | ||
| import { deserializeTransaction, estimateTransaction } from '@stacks/transactions'; | ||
| import { isLedgerAccount, microStxToStx } from '@utils/helper'; |
There was a problem hiding this comment.
nit: xverse-core already exports stxToMicrostacks and microstacksToStx
Suggested change
| stxToMicrostacks, | |
| StxTransactionData, | |
| } from '@secretkeylabs/xverse-core'; | |
| import { deserializeTransaction, estimateTransaction } from '@stacks/transactions'; | |
| import { isLedgerAccount, microStxToStx } from '@utils/helper'; | |
| stxToMicrostacks, | |
| microstacksToStx | |
| StxTransactionData, | |
| } from '@secretkeylabs/xverse-core'; | |
| import { deserializeTransaction, estimateTransaction } from '@stacks/transactions'; | |
| import { isLedgerAccount } from '@utils/helper'; |
There was a problem hiding this comment.
The downside here is that microstacksToStx requires a BigNumber-only param, but of course we can convert it
|
@dhriaznov thanks for making the code improvements. let's merge this after the base branch is merged |
teebszet
changed the base branch from
denys/eng-3436-make-some-code-refactoring-for-rbf-in-the-extension
to
develop
…on into denys/eng-3474-make-ui-for-stx-rbf-in-the-extension
|
Thanks for the review @teebszet! I resolved the git conflicts and applied the above code suggestions |
teebszet
previously approved these changes
Jan 10, 2024
|
@dhriaznov needs conflicts resolved |
…on into denys/eng-3474-make-ui-for-stx-rbf-in-the-extension
|
Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7489716984 |
teebszet
approved these changes
Jan 11, 2024
teebszet
deleted the
denys/eng-3474-make-ui-for-stx-rbf-in-the-extension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
What kind of change does this PR introduce?
📜 Background
This feature is needed to help our Stacks users increase the chance of getting their pending transactions included in the next Stacks anchor block, by increasing the transaction fee.
Issue Link: #[ENG-3474]
Context Link (if applicable):
🔄 Changes
useRbfTransactionDatahooksrc/app/components/transactions/stxTransferTransaction.tsxcomponentsrc/app/components/transactions/stxTransaction.tsxcomponentsrc/assets/img/transactions/increaseFee.svgiconImpact:
🖼 Screenshot / 📹 Video
The demo videos are in the linear ticket.
✅ Review checklist
Please ensure the following are true before merging: