Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new auto lock period values and migrate users if needed #736

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

fedeerbes
Copy link
Contributor

🔘 PR Type

  • Enhancement

📜 Background

This PR adds new auto lock period options and migrates users from older values (1' or 10') to new low value 15' if needed. Default value now is 30'

Issue Link: #ENG-3527

Impact:

  • Auto lock flow, setting and lock/unlock logic

🖼 Screenshot / 📹 Video

NORMAL FLOW SIMULATED UPDATE
Screen.Recording.2024-01-05.at.12.00.46.mov
Screen.Recording.2024-01-05.at.12.05.38.mov

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@dhriaznov
Copy link
Contributor

It looks like currently the 15 minutes option timer icon has opacity set to 1, but all other icons have 0.8. I took a look at figma and from what I see it should be dynamic, so that the active option icon should have an opacity 1 and all other icons should have 0.8

https://www.figma.com/file/FCk8jDMsC8UEfPSWnqewLY/Xverse-%E2%80%94-Extension-V2?node-id=11693%3A13820&mode=dev

@fedeerbes fedeerbes self-assigned this Jan 8, 2024
@fedeerbes
Copy link
Contributor Author

It looks like currently the 15 minutes option timer icon has opacity set to 1, but all other icons have 0.8. I took a look at figma and from what I see it should be dynamic, so that the active option icon should have an opacity 1 and all other icons should have 0.8

https://www.figma.com/file/FCk8jDMsC8UEfPSWnqewLY/Xverse-%E2%80%94-Extension-V2?node-id=11693%3A13820&mode=dev

you're right, thanks! i took them from mobile and i didn't check that detail. will make the change

Copy link

github-actions bot commented Jan 8, 2024

Copy link
Contributor

@dhriaznov dhriaznov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teebszet teebszet merged commit 2f7a7dc into develop Jan 11, 2024
5 checks passed
This was referenced Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants