Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update:
list_to_binary/1
replaceio:iodata_to_binary/1
, because we already known it's a list.<< random, acc::binary>>
replace<< acc::binary, random>>
, make sure benchmark more fair.Great to know!!
[item|list]
is faster than<<item, list/binary>>
But binary construction is more flexible then list construction
we can do
if it a list, we only can do