fixed random module is deprecated compile warning

[zhongwencool]

No description provided.

[coveralls]

Coverage remained the same at 97.984% when pulling e0641f9 on random-deprecated-erlang-19 into 67549b5 on master.

[coveralls]

Coverage remained the same at 97.984% when pulling cc6fc6b on random-deprecated-erlang-19 into 67549b5 on master.

[coveralls]

Coverage remained the same at 97.984% when pulling 4ef460b on random-deprecated-erlang-19 into 67549b5 on master.

[secretworry]

Why don't we just implement the unique/2 like this

def unique(n) when n > 0, do: Enum.map(1..n, fn _ -> Enum.random(?a..?z) end) |> IO. iodata_to_binary
def unique(_), do: ""

The iodata_to_binary, which is a BIF, will save more memory, and be more effecient.

[zhongwencool]

@secretworry your solution just like：

defp unique(size, acc\\[])
defp unique(0, acc), do: acc |> IO.iodata_to_binary
defp unique(size, acc) do
    random = Enum.random(?a..?z)
    unique(size - 1, [random|acc])
end

the size only 16
so two method almost the same.
when the binary is small size , it's work just as list.
<<random, acc_binary::binary>> 's efficiency just as [random|acc_list]
So we don't need IO.iodata_to_binary/1

[secretworry]

I did a little benchmark here, my solution is slower than the one you gave. The best would be list loop + IO.iodata_to_binary.

[zhongwencool]

secretworry/benchex#1
Happy to know, I will change it to list loop +:erlang.list_to_binary later.
@secretworry