Fixes #54: Microsoft FTP Service directory format. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft FTP Service directory listing format is having different from Unix format. This fix handles the fallback (Unix first MS next) to achieve ReadDir compatibility.
Open
benmanns
reviewed
Dec 23, 2021
| matches[3] = "rwx" | ||
| matches[4] = "rwx" | ||
| if d, e := time.Parse("01-02-06", msmatches[1]); e == nil { | ||
| matches[6] = d.Format("Jan _2") |
There was a problem hiding this comment.
We're losing the year here. I noticed when parsing a Feb 29, 2008 date causing an error on re-parsing, but this will be an issue for any year prior to the current one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft FTP Service directory listing format is having different from Unix format.
This fix handles the fallback (Unix first MS next) to achieve ReadDir compatibility.