Including Test Setup for Swift #587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jusito feedback appreciated :) |
|
The pr is ready to be merged. |
jusito
suggested changes
Feb 16, 2023
removed unused code
|
This looks pretty overlapping to #585 , do we still need/want this? |
I intentionally splitted it in two PRs so it's easier to review the changes. This one just includes the changes to the test setup, the other one changes to the analysis + new tests utilizing this new test setup. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
unittests/PhasarLLVM/DataFlow/IfdsIde/Problems/IDELinearConstantAnalysisSwiftTest.cpp
Outdated
Show resolved
Hide resolved
unittests/PhasarLLVM/DataFlow/IfdsIde/Problems/IDELinearConstantAnalysisSwiftTest.cpp
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
closing this according to private conversation with @janniclas |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I added the possibility to compile Swift test cases to LLVM IR.
The idea is to include this as an optional setting with default to set OFF, so our users can decide whether they want to run those locally. However, I would like to include the tests in our build pipeline to make sure that we are notified if changes affect the Swift-based LLVM IR.