Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/ens owner px tests #1

Merged
merged 11 commits into from
May 21, 2018
Merged

F/ens owner px tests #1

merged 11 commits into from
May 21, 2018

Conversation

XertroV
Copy link
Member

@XertroV XertroV commented May 21, 2018

Add tests for ensOwnerProxy and ensEverythingPx

  • also refactor the everythingPx to use hasAdmins

@XertroV XertroV merged commit 0ba1f12 into master May 21, 2018
@XertroV XertroV deleted the f/EnsOwnerPxTests branch May 21, 2018 04:03
@coveralls
Copy link

coveralls commented May 21, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 66

  • 18 of 22 (81.82%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.3%) to 64.351%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/SVLightAdminProxy.sol 2 4 50.0%
contracts/SVLightIndex.sol 1 3 33.33%
Totals Coverage Status
Change from base Build 54: 8.3%
Covered Lines: 390
Relevant Lines: 587
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XertroV @coveralls