Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Improve arachni result polling mechanics #14

Merged
merged 4 commits into from
Oct 18, 2019
Merged

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Oct 1, 2019

Improved how the scanner wrapper polls the arachni api server for the finished results.

  • Use /scans/:scanId/summary instead of the full /scans/:scanId/ endpoint. This greatly reduced load on the api server as the responses are way smaller.
  • In case of polling timeouts the wrapper will only fail if it gets 10 consecutive timeouts / errors. If the wrapper get a successful response the counter is reset.
  • Increased polling timeout from 2 to 5 seconds and the final result fetch timeout from 2 to 60

@J12934 J12934 requested a review from rseedorff October 2, 2019 14:28
Copy link
Member

@rseedorff rseedorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Thx for that

@rseedorff rseedorff merged commit cacd061 into master Oct 18, 2019
@J12934 J12934 deleted the handle-polling-timeouts branch January 16, 2020 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants