Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests fail on jest version higher than 27.0.6 #1425

Closed
Ilyesbdlala opened this issue Nov 1, 2022 · 1 comment
Closed

Unit tests fail on jest version higher than 27.0.6 #1425

Ilyesbdlala opened this issue Nov 1, 2022 · 1 comment
Assignees
@Ilyesbdlala
Labels
bug Bugs

Comments

@Ilyesbdlala
Copy link
Member

Ilyesbdlala commented Nov 1, 2022 •
edited
Loading

🐞 Bug report

After the automatic upgrade of Jest to the latest version (29.2.1 at the time), we realized that our CI fails (Example). The temporary fix was to set Jest to known working version 27.0.6 (#1415). This resolved the issue. However, the use of an older version of Jest
allowed the use of vulnerable packages, as seen here and from the Dependabot from the package minimatch@3.0.4.

Steps To Reproduce

Run any hooks unit tests with a "newer" version of jest. It is not clear at which version exactly the issue starts to appear.

Expected behaviour

Tests should run successfully with newer Jest versions. Refactoring of tests is needed

Additional context
@Ilyesbdlala Ilyesbdlala added the bug Bugs label Nov 1, 2022
@Ilyesbdlala Ilyesbdlala mentioned this issue Nov 1, 2022
Closed
@Ilyesbdlala Ilyesbdlala self-assigned this Jan 23, 2023
@Weltraumschaf Weltraumschaf mentioned this issue Jan 26, 2023
Closed
Ilyesbdlala added a commit that referenced this issue Feb 1, 2023
@Ilyesbdlala
refactor(hook-ci): #1425 Only run integrations tests if "integration-…
8d6d4c2 
…tests" folder exists

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala added a commit that referenced this issue Feb 1, 2023
@Ilyesbdlala
maitenance(jest): #1425 Updated jest, ts-jest and @tyoes/jest in pack…
06f296d 
…age.json and package-lock.json

jest: 27.0.6 --> 29.3.1
ts-jest: 27.03 --> 29.0.5
@types/jest: 26.0.24 --> 29.4.0
jest-runner-eslint: 0.10.1 --> 1.1.0

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala added a commit that referenced this issue Feb 1, 2023
@Ilyesbdlala
maintenance(jest): #1425 Updated scanner snapshots to fit the updated…
3269cf5 
… format of jest v29.3.1

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala added a commit that referenced this issue Feb 7, 2023
@Ilyesbdlala
refactor(hook-ci): #1425 Only run integrations tests if "integration-…
a01dbff 
…tests" folder exists

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala added a commit that referenced this issue Feb 7, 2023
@Ilyesbdlala
maitenance(jest): #1425 Updated jest, ts-jest and @tyoes/jest in pack…
b3283de 
…age.json and package-lock.json

jest: 27.0.6 --> 29.3.1
ts-jest: 27.03 --> 29.0.5
@types/jest: 26.0.24 --> 29.4.0
jest-runner-eslint: 0.10.1 --> 1.1.0

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala added a commit that referenced this issue Feb 7, 2023
@Ilyesbdlala
maintenance(jest): #1425 Updated scanner snapshots to fit the updated…
16a9f6d 
… format of jest v29.3.1

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Weltraumschaf pushed a commit that referenced this issue Feb 7, 2023
@Ilyesbdlala @Weltraumschaf
refactor(hook-ci): #1425 Only run integrations tests if "integration-…
4d30266 
…tests" folder exists

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Weltraumschaf pushed a commit that referenced this issue Feb 7, 2023
@Ilyesbdlala @Weltraumschaf
maitenance(jest): #1425 Updated jest, ts-jest and @tyoes/jest in pack…
c726bf5 
…age.json and package-lock.json

jest: 27.0.6 --> 29.3.1
ts-jest: 27.03 --> 29.0.5
@types/jest: 26.0.24 --> 29.4.0
jest-runner-eslint: 0.10.1 --> 1.1.0

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Weltraumschaf pushed a commit that referenced this issue Feb 7, 2023
@Ilyesbdlala @Weltraumschaf
maintenance(jest): #1425 Updated scanner snapshots to fit the updated…
4aaa809 
… format of jest v29.3.1

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Copy link
Member Author

Closed by #1567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ilyesbdlala Ilyesbdlala

Labels
bug Bugs
Projects
secureCodeBox v4
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ilyesbdlala