Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow wildcards in CascadingRules (closes #357) #374

Merged
merged 7 commits into from
Apr 19, 2021
Merged

Allow wildcards in CascadingRules (closes #357) #374

merged 7 commits into from
Apr 19, 2021

Conversation

luckolen
Copy link
Contributor

Description

This PR add the option for users to use the * as a wildcard when defining CascadingRules. For instance http* will match everything starting with http and as a result one rule can do both http and https.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@rseedorff rseedorff added the scanner Implement or update a security scanner label Apr 14, 2021
@rseedorff rseedorff added this to In Progress in secureCodeBox v2 via automation Apr 14, 2021
@rseedorff rseedorff added this to the v2.7.0 milestone Apr 14, 2021
J12934
J12934 reviewed Apr 15, 2021
View reviewed changes
hooks/declarative-subsequent-scans/hook.ts Outdated Show resolved Hide resolved
hooks/declarative-subsequent-scans/hook.ts Outdated Show resolved Hide resolved
@J12934 J12934 added enhancement New feature or request hook Implement or update a hook and removed scanner Implement or update a security scanner labels Apr 15, 2021
luckolen and others added 2 commits April 15, 2021 15:46
@luckolen @J12934
Import cleanup
84671cf 
Co-authored-by: Jannik Hollenbach <jannik@hollenbach.de>
@luckolen-secura
Implemented matcher.isMatch for wildcard matching
5884c89
@luckolen luckolen changed the title Allow wildcards in CascadingRules by using * (closes #357) Allow wildcards in CascadingRules (closes #357) Apr 15, 2021
@J12934 J12934 merged commit 0d6295c into secureCodeBox:main Apr 19, 2021
secureCodeBox v2 automation moved this from In Progress to Done Apr 19, 2021
@J12934 J12934 mentioned this pull request Apr 19, 2021
Merged
3 tasks
@luckolen luckolen deleted the CascadingRules-Wildcard branch April 22, 2021 14:16
@J12934 J12934 moved this from Done to counter in secureCodeBox v2 Apr 23, 2021
@rseedorff rseedorff removed the enhancement New feature or request label Apr 23, 2021
@rseedorff rseedorff added the enhancement New feature or request label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J12934 J12934 J12934 left review comments

Assignees
No one assigned
Labels
enhancement New feature or request hook Implement or update a hook
Projects
No open projects
secureCodeBox v2
counter
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luckolen @J12934 @rseedorff @luckolen-secura