Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for wildcards in cascading rules #380

Merged
merged 5 commits into from
Apr 26, 2021
Merged

Add unit test for wildcards in cascading rules #380

merged 5 commits into from
Apr 26, 2021

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Apr 19, 2021 •
edited by rseedorff

Followup after #374

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@J12934 J12934 added testing Improvements or additions regarding the test setup hook Implement or update a hook labels Apr 19, 2021
@J12934 J12934 self-assigned this Apr 19, 2021
@J12934 J12934 added this to In Progress in secureCodeBox v2 via automation Apr 19, 2021
@rseedorff rseedorff moved this from In Progress to To Review in secureCodeBox v2 Apr 23, 2021
@rseedorff rseedorff moved this from To Review to In Progress in secureCodeBox v2 Apr 23, 2021
@fuhrmeistery fuhrmeistery merged commit f2a06b9 into main Apr 26, 2021
secureCodeBox v2 automation moved this from In Progress to Done Apr 26, 2021
@fuhrmeistery fuhrmeistery deleted the tests/wildcard-unit-test branch April 26, 2021 08:02
@rseedorff rseedorff removed the hook Implement or update a hook label May 1, 2021
@J12934 J12934 moved this from Done to counter in secureCodeBox v2 May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuhrmeistery fuhrmeistery fuhrmeistery approved these changes

Assignees

@J12934 J12934

Labels
testing Improvements or additions regarding the test setup
Projects
No open projects
secureCodeBox v2
counter
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@J12934 @fuhrmeistery @rseedorff