Address go vet failure in SQL rule

securego · Nov 3, 2016 · 686927c · 686927c
1 parent 344ebd1
commit 686927c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/rules/sql.go b/rules/sql.go
@@ -30,10 +30,12 @@ type SqlStrConcat struct {
 	SqlStatement
 }
 
-// see if we can figgure out what it is
+// see if we can figure out what it is
 func (s *SqlStrConcat) checkObject(n *ast.Ident) bool {
 	if n.Obj != nil {
-		return (n.Obj.Kind != ast.Var || n.Obj.Kind != ast.Fun)
+		// TODO(gm): Revisit logic used here.
+		//return (n.Obj.Kind != ast.Var || n.Obj.Kind != ast.Fun)
+		return n.Obj.Kind != ast.Var && n.Obj.Kind != ast.Fun
 	}
 	return false
 }