Prevent null pointer exception in Sonarqube #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the json encoding of uninitialized arrays is null. this causes a npe in sonarqube tool. we should return an empty array rather than a null value here. relates to: securego#333
houndci-bot
reviewed
Jul 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
=======================================
Coverage 65.72% 65.72%
=======================================
Files 9 9
Lines 566 566
=======================================
Hits 372 372
Misses 174 174
Partials 20 20Continue to review full report at Codecov.
|
MVrachev
pushed a commit
to MVrachev/gosec
that referenced
this pull request
Jul 31, 2019
* fix(formatters) null value causes npe in sonarqube the json encoding of uninitialized arrays is null. this causes a npe in sonarqube tool. we should return an empty array rather than a null value here. relates to: securego#333
MVrachev
pushed a commit
to MVrachev/gosec
that referenced
this pull request
Jul 31, 2019
* fix(formatters) null value causes npe in sonarqube the json encoding of uninitialized arrays is null. this causes a npe in sonarqube tool. we should return an empty array rather than a null value here. relates to: securego#333
MVrachev
pushed a commit
to MVrachev/gosec
that referenced
this pull request
Jul 31, 2019
* fix(formatters) null value causes npe in sonarqube the json encoding of uninitialized arrays is null. this causes a npe in sonarqube tool. we should return an empty array rather than a null value here. relates to: securego#333
MVrachev
pushed a commit
to MVrachev/gosec
that referenced
this pull request
Jul 31, 2019
* fix(formatters) null value causes npe in sonarqube the json encoding of uninitialized arrays is null. this causes a npe in sonarqube tool. we should return an empty array rather than a null value here. relates to: securego#333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json encoding of uninitialized arrays is
null. This causes a NPE in sonarqube tool. We should return an empty array rather than a null value here.Example of this behaviour is: https://play.golang.org/p/UUvP9JwsYlm
Relates to: #333