Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julian add cwe rulemappings #405

Merged
merged 6 commits into from
Oct 31, 2019
Merged

Julian add cwe rulemappings #405

merged 6 commits into from
Oct 31, 2019

Conversation

julianthome
Copy link
Contributor

Fixes #368

Add CWE rule mappings to gosec rules.

@codecov-io
Copy link

codecov-io commented Oct 20, 2019

Codecov Report

Merging #405 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   71.14%   71.14%           
=======================================
  Files           9        9           
  Lines         596      596           
=======================================
  Hits          424      424           
  Misses        154      154           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c1128...dcd98c0. Read the comment docs.

Copy link
Member

@ccojocar ccojocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! It looks great. I am just wondering if you can add a unit test in the formatter_test.go to validate the mapping. Thanks

@julianthome
Copy link
Contributor Author

Thanks for this contribution! It looks great. I am just wondering if you can add a unit test in the formatter_test.go to validate the mapping. Thanks

Yes sure! Will add some unit tests.

@julianthome
Copy link
Contributor Author

julianthome commented Oct 29, 2019

I have added test cases for the report generator.
@ccojocar please let me know if you want me to apply further changes.

Copy link
Member

@ccojocar ccojocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! Thank you!

@ccojocar ccojocar merged commit 53be8dd into securego:master Oct 31, 2019
@julianthome julianthome deleted the julian-add-cwe-rulemappings branch October 31, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map gosec rules to CWEs
3 participants