-
-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julian add cwe rulemappings #405
Julian add cwe rulemappings #405
Conversation
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 71.14% 71.14%
=======================================
Files 9 9
Lines 596 596
=======================================
Hits 424 424
Misses 154 154
Partials 18 18 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution! It looks great. I am just wondering if you can add a unit test in the formatter_test.go
to validate the mapping. Thanks
Yes sure! Will add some unit tests. |
I have added test cases for the report generator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution! Thank you!
Fixes #368
Add CWE rule mappings to gosec rules.