Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add-missing-metadata #331

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: add-missing-metadata #331

merged 1 commit into from
Apr 18, 2024

Conversation

JasonPowr
Copy link
Contributor

This pr makes the changes necessary to display missing metadata in the operator marketplace
Jira: https://issues.redhat.com/browse/SECURESIGN-801

Screenshot from 2024-04-18 10-04-32

Testing

Here is an CatalogSource yaml definition you can use if you want to test, with my FBC image

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: rhtas-operator-japower
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  grpcPodConfig:
    securityContextConfig: legacy
  publisher: Red Hat
  image: quay.io/japower/4.15_test@sha256:1cee7ca01822206d8aa154614fde8119a2b8769f63a6a21047987b7f8e124c6c
  displayName: TAS Operator

Copy link

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonPowr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JasonPowr JasonPowr changed the title add-missing-metadata fix: add-missing-metadata Apr 18, 2024
@JasonPowr
Copy link
Contributor Author

The ci/prow/tas-operator-e2e test is failing because the namespace is hard-coded in https://github.com/securesign/secure-sign-operator/blob/main/config/samples/rhtas_v1alpha1_securesign.yaml#L9

./ci/openshift/sign-test.sh
namespace/securesign created
error: the namespace from the provided object "rhtas-operator" does not match the namespace "securesign". You must pass '--namespace=rhtas-operator' to perform this operation.

I have a fix for this in this pr: #301, specifically here:
https://github.com/securesign/secure-sign-operator/pull/301/files#diff-f7096fd10c4716597c46bd5828440d342e900e4c9aa2a546e5c240ac86162142

features.operators.openshift.io/token-auth-azure: "false"
features.operators.openshift.io/token-auth-gcp: "false"
repository: https://github.com/securesign/secure-sign-operator
support: Red Hat
name: rhtas-operator.v0.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.0.1 look like some remaining from old release

@osmman
Copy link
Contributor

osmman commented Apr 18, 2024

/lgtm

@osmman
Copy link
Contributor

osmman commented Apr 18, 2024

/override ci/prow/tas-operator-e2e

Copy link

openshift-ci bot commented Apr 18, 2024

@osmman: Overrode contexts on behalf of osmman: ci/prow/tas-operator-e2e

In response to this:

/override ci/prow/tas-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 648c408 into main Apr 18, 2024
10 checks passed
@osmman osmman deleted the add-missing-metadata branch April 18, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants