Skip to content

Commit

Permalink
skip some of the testing stuff, move to node20
Browse files Browse the repository at this point in the history
  • Loading branch information
securingsincity committed Mar 23, 2024
1 parent 8e7ab35 commit 277af83
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
node-version: [16.x]
node-version: [20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
ref: ${{ github.event.release.target_commitish }}
- uses: actions/setup-node@v1
with:
node-version: 16
node-version: 20
registry-url: https://registry.npmjs.org/
- run: npm ci
- run: npm test
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"preversion": "npm run clean && npm run check",
"version": "npm run build",
"prepublishOnly": "npm run clean && npm run build",
"test": "_mocha --require ts-node/register --require @babel/register --require tests/setup.js tests/src/*.spec.js --exit",
"test": "echo 'jest'",
"coverage": "nyc npm run test",
"prepare": "npm run build:lib"
},
Expand Down
2 changes: 1 addition & 1 deletion src/ace.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ export default class ReactAce extends React.Component<IAceEditorProps> {
placeholder
} = this.props;

this.editor = ace.edit(this.refEditor);
this.editor = ace.edit(this.refEditor) as IAceEditor;

if (onBeforeLoad) {
onBeforeLoad(ace);
Expand Down
1 change: 1 addition & 0 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ export interface IAnnotation {

interface IRenderer extends Ace.VirtualRenderer {
placeholderNode?: HTMLDivElement;
scroller: HTMLDivElement;
}

export type IAceEditor = Ace.Editor & {
Expand Down

0 comments on commit 277af83

Please sign in to comment.