Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The background colour of the terminal seems to change for no reason since 0.43 #209

Closed
cobrabr opened this issue Sep 2, 2019 · 11 comments

Comments

@cobrabr
Copy link

@cobrabr cobrabr commented Sep 2, 2019

image

Notice the difference in colour between the border and the terminal itself.

Originally posted by @cobrabr in #206 (comment)

@sedwards2009

This comment has been minimized.

Copy link
Owner

@sedwards2009 sedwards2009 commented Sep 13, 2019

I've tracked this down to being a hardware acceleration related problem. The composition of the different elements on the screen is slightly incorrect for certain operating systems and GPUs/graphics cards. It is not just the background colour that is wrong. The whole terminal part is about 10% darker than it should be (on macOS).

@sedwards2009 sedwards2009 referenced this issue Sep 15, 2019
110 of 132 tasks complete
@sedwards2009

This comment has been minimized.

Copy link
Owner

@sedwards2009 sedwards2009 commented Oct 11, 2019

Fixed in v0.46.0.

@cobrabr

This comment has been minimized.

Copy link
Author

@cobrabr cobrabr commented Oct 11, 2019

Still happening for me:
image

@sedwards2009

This comment has been minimized.

Copy link
Owner

@sedwards2009 sedwards2009 commented Oct 12, 2019

Is the "reduce graphics" option turned on in the Settings?

@sedwards2009

This comment has been minimized.

Copy link
Owner

@sedwards2009 sedwards2009 commented Oct 12, 2019

Also, what GPU chip are you using? I could reproduce this problem on macOS with some old-ish Intel integrated GPU, but I don't have a Windows machine which does the same.

@cobrabr

This comment has been minimized.

Copy link
Author

@cobrabr cobrabr commented Oct 12, 2019

I've tried it with both it on and off, with the same results. My GPU is a GeForce RTX 2070.

I also noticed that, while in the Settings tab, if I hover the mouse over between the tab title and the tab itself, the background color flickers between the right colour and the darker one there as well:

2019-10-12_18-29-01

@cobrabr

This comment has been minimized.

Copy link
Author

@cobrabr cobrabr commented Oct 12, 2019

I don't know if this helps, but I noticed that the effect is different depending on the theme. If I choose "xterm", for example, this is what I get in Settings > Appearance:

image

And this is what the actual terminal looks like:

image

However, the flicker that I mentioned on my previous post looks different:

2019-10-12_18-34-45

@sedwards2009

This comment has been minimized.

Copy link
Owner

@sedwards2009 sedwards2009 commented Oct 13, 2019

My first advice is to keep your graphics driver up to date. Updating the Electron version at my end may fix the problem or it may not. One thing which probably will work is to add an option to disable hardware acceleration. I don't really want people getting a slow Extraterm experience but it looks like the option is still needed in your case @cobrabr .

@sedwards2009 sedwards2009 reopened this Oct 13, 2019
@sedwards2009 sedwards2009 removed the fixed label Oct 13, 2019
@cobrabr

This comment has been minimized.

Copy link
Author

@cobrabr cobrabr commented Oct 15, 2019

I have the latest NVidia driver, so we're good there. It's weird because it used to work before, and the GPU was the same back then. I could try installing the latest version at work, where the hardware is completely different to see if I get different results, but I don't know if that'll help.

sedwards2009 added a commit that referenced this issue Nov 6, 2019
issue #209
@sedwards2009

This comment has been minimized.

Copy link
Owner

@sedwards2009 sedwards2009 commented Nov 15, 2019

Option to disable HW acceleration added in v0.47.0.

@cobrabr

This comment has been minimized.

Copy link
Author

@cobrabr cobrabr commented Nov 17, 2019

Looks like disabling HW acceleration did the trick. However, after turning it off and restarting ExtraTerm, whenever I open the Settings tab, HW acceleration is checked on and asking for a restart (even though I didn't check the checkbox on myself):

image

If I restart it again without changing anything, HW acceleration is on and the problem comes back (at which point I have to turn it back off and restart one more time).

TL;DR, HW acceleration turns itself back on every other restart unless I manually turn it off every time I restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.