Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rosetta stone updates #5

Merged
merged 3 commits into from
Dec 4, 2019
Merged

Rosetta stone updates #5

merged 3 commits into from
Dec 4, 2019

Conversation

MartinKavik
Copy link
Member

Changes

  • cargo.toml - seed 0.5.0.
  • Updated Seed version on homepage.
  • Adapted to Seed 0.5.0 + cargo make verify passes.
  • Added guide code_comparison into the menu.
  • highlight.js can't highlight tsx and fails when you add HTML into the code. jsx should be enough, we'll fix it once Add tsx (TypeScript + JSX) support highlightjs/highlight.js#1663 is merged.
  • Seed example in code_comparison - I've replaced #[macro_use].. with seed::* because macros are in the root and compilation fails without it, because App isn't in prelude but also in the root.

@David-OConnor David-OConnor merged commit 58d2429 into rosetta-stone Dec 4, 2019
@David-OConnor David-OConnor deleted the rosetta-stone-updates branch February 8, 2020 01:45
@MartinKavik MartinKavik mentioned this pull request May 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinKavik @David-OConnor