Examples/charts #467
Closed
Examples/charts #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TatriX
force-pushed
the
examples/charts
branch
2 times, most recently
from
870e1d2
to
213de47
Compare
MartinKavik
requested changes
Aug 9, 2020
Co-authored-by: Martin Kavík <martin@kavik.cz>
TatriX
force-pushed
the
examples/charts
branch
from
eeef0d5
to
57445dc
Compare
MartinKavik
reviewed
Aug 14, 2020
Comment on lines
+116
to
+117
| let onenter = onenter.clone(); | ||
| let onout = onout.clone(); |
MartinKavik
requested changes
Aug 14, 2020
Merged
|
closing in favor of #664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a chart example.
It's a bit messy right now, as a lot of things are hardcoded and not properly structured.
But it should be good enough to serve as a starting point.
As you can see in the dev tools, there is a
xmlnsattribute on every svg node. I believe all of those can be removed: see "note" on the mdn