Disable AOSP K/V Call log backups #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K/V Backup of call logs creates one pair per call log entry, thus leading to thousands of files for people with lots of logs. This is really slow especially with Nextcloud, making the backup take hours. Fix that by not enabling the AOSP K/V code, and instead using our own full backup code. Full Backup implementation: https://review.calyxos.org/c/CalyxOS/platform_packages_providers_ContactsProvider/+/2970 Issue: calyxos#395 Issue: #127 Change-Id: I742408ab62e126129966f7c9d095d6e61fdc58f6
|
@grote one thing I noticed with this change is, if you have an old backup with the K/V backup, and then upgrade to a build with this which makes a full backup - restore still restores both backups. I was thinking of disabling If not, maybe we need to add some code here. |
|
Won't be needed after #127 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K/V Backup of call logs creates one pair per call log entry, thus
leading to thousands of files for people with lots of logs.
This is really slow especially with Nextcloud, making the backup take hours.
Fix that by not enabling the AOSP K/V code, and instead using our own
full backup code.
Full Backup implementation: https://review.calyxos.org/c/CalyxOS/platform_packages_providers_ContactsProvider/+/2970
Issue: calyxos#395
Issue: #127
Issue: #224
Change-Id: I742408ab62e126129966f7c9d095d6e61fdc58f6