Table with default foreign key naming strategy #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update travis configuration - Remove test fixtures - Add MySQL knexfile
- Update travis configuration - Remove test fixtures - Add MySQL knexfile
…ature/mysql-support
- Update travis configuration - Remove test fixtures - Add MySQL knexfile
…ature/mysql-support
|
This is not sync with the current tree of #7. Can you please rebase and only leave your commits to be merged? |
| @@ -333,5 +332,13 @@ describe('bookshelf-cascade-delete', () => { | |||
|
|
|||
| sinon.restore(Model); | |||
| }); | |||
|
|
|||
| it('should foreignKey', async () => { | |||
There was a problem hiding this comment.
What are you trying to accomplish here?
There was a problem hiding this comment.
This test is useless. I used it to check if forgeinKey is undfined.
|
@Bartinger I already spotted the bug, working on it. Thanks! |
ricardogama
force-pushed
the
feature/mysql-support
branch
2 times, most recently
from
f951d54
to
69dd60e
Compare
|
@Bartinger This bug is something different than what was fixed in #7, so I'll close this PR for now and open an issue to keep track of it. |
|
@Bartinger Can you take a look at the comment I just made on #9? It seems that the schema you created was malformed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same error still occurs. Because of the quotes around "Post_id" postgres dosn't find the column post_id